RSDK-7627, RSDK-7660, RSDK-7480: removes PIL, adds two new methods get_properties and capture_all_from_camera #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhaney
changed the title
kharijarrett
approved these changes
May 21, 2024
src/verificationclassifier.py
Outdated
|
|
||
| from viam.module.types import Reconfigurable | ||
| from viam.proto.app.robot import ComponentConfig | ||
| from viam.proto.service.vision import Classification | ||
| from viam.proto.common import ResourceName | ||
| from viam.proto.service.vision import Classification, Detection |
There was a problem hiding this comment.
Do you actually need to import Detection and PointCloudObject?
There was a problem hiding this comment.
good point - I'll remove them
| timeout: Optional[float] = None, | ||
| ) -> CaptureAllResult: | ||
| result = CaptureAllResult() | ||
| if camera_name != self.camera_name: |
There was a problem hiding this comment.
I don't think we can do anything about this but I still dislike (even more now) that we need to include camera names in the config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the module to be ready for the viam-sdk version 0.21.0